hbz / oerworldmap

OER World Map
https://oerworldmap.org/
Other
30 stars 16 forks source link

Allow logo upload #647

Open trugwaldsaenger opened 8 years ago

trugwaldsaenger commented 8 years ago

As an editor I would like to upload logos to the platform. This would be helpful in the case, that a trusted link to the logo cannot be found.

literarymachine commented 8 years ago

For clarification: @philboeselager implemented the back end side of this in #572, we haven't had a chance yet to pull this into the front end though.

mandrasch commented 5 years ago

I like the upload file / add file via URL option on www.uploadcare.com

image

Unbenannt12312132

tamielbr commented 5 years ago

It seems like this might be important in cases where image location exists, is valid, but doesn't seem to get pulled, for example:

literarymachine commented 5 years ago

It seems like this might be important in cases where image location exists, is valid, but doesn't seem to get pulled, for example:

Interesting that you are experiencing this right away, this behavior has been implemented a couple of hours ago in https://github.com/hbz/oerworldmap-ui/pull/569. We are stripping the scheme part of the image url, effectively always requesting them via https. Non of the images in the above examples can be requested properly using https.

mandrasch commented 5 years ago

Mh the same problem Google, Firefox & Co are facing regarding their move to forbid http :) :/ https://www.engadget.com/2019/10/04/chrome-security-block-http-content/?guccounter=1

What about image caching (User enters URL, World Map copies it to a file storage, like a CDN?)? It would also solve the privacy challenge regarding connections to third party pages.