search

hcavarsan / kftray

kubectl port-forward on steroids 🦀 | manage and share multiple k8s port forwards - with support for UDP, proxy through the k8s cluster, and github state sync.
https://kftray.app/
MIT License
787 stars 70 forks source link

feat: better error handling to toggle port forwards #207

Closed hcavarsan closed 4 months ago

hcavarsan commented 4 months ago

feat: better error handling to toggle port forwards

CleanShot 2024-05-01 at 21 19 39

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates encompass a range of enhancements across the application. These include configuration migration, refined error handling for port forwarding operations, and user interface improvements in settings and modal components. The changes collectively aim to streamline user interactions, provide better error feedback, and ensure a smoother configuration experience.

Changes

Files Change Summary
src-tauri/src/commands.rs Added use crate::config::migrate_configs; and initiated migration of configs using migrate_configs() function.
src/assets/style.css Corrected the indentation within the .accordion-shadow class properties in src/assets/style.css.
src/components/AddConfigModal/index.tsx Refactored the onChange handler in the AddConfigModal component for better readability, eliminating unnecessary type casting in the event passing to handleInputChange.
src/components/PortForwardRow/index.tsx Added Text and useToast imports, enhanced startPortForwarding and stopPortForwarding functions to manage errors and display toast messages, and introduced toast as a parameter to these functions.
src/components/SettingsModal/index.tsx Updated the SettingsModal component by restructuring form elements layout, implementing conditional rendering for Git Token input based on a checkbox, and adjusting button actions within the modal for improved functionality.
src/components/KFtray/index.tsx Enhanced the KFTray component by incorporating error notification handling for failed configurations import, and removing unnecessary assignment statements during function invocation based on configuration types.

Possibly related issues

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 56166bc5a838335e16987995d92c161628ce581f and 78120ee0122783669c164664a999f60dea3e5120.
Files ignored due to path filters (1) * `dist/index.html` is excluded by `!dist/**`, `!dist/**`
Files selected for processing (3) * src-tauri/src/commands.rs (2 hunks) * src/components/KFtray/index.tsx (3 hunks) * src/components/PortForwardRow/index.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (3) * src-tauri/src/commands.rs * src/components/KFtray/index.tsx * src/components/PortForwardRow/index.tsx
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.