search

hcavarsan / kftray

manage multiple kubectl port-forward commands, with support for UDP, K8s proxy, and github state sync.
https://kftray.app/
MIT License
740 stars 70 forks source link

Port-forward to pods not available #260

Closed allemp closed 2 months ago

allemp commented 2 months ago

Describe the bug

Issue #23 mentions that it should be possible to port-forward to pods, but only service and proxy are available in the workload type list

Expected behavior

I expected to be able to select pods as a workload type to to select the pod I want to forward.

Desktop (please complete the following information):

Additional context

If it was not intentional to allow port-forwarding to pods or I missed something then disregard.

Thanks!

hcavarsan commented 2 months ago

hey @allemp ,

i've thought about this and didn't implement port-forward directly to pods because if it's a specific pod name, the config will only be valid while the pod is running. once the pod is terminated, the config in kftray would stop working.

but i get that today you need a service created for port-forward to work, and this doesn't cover some cases.

what i'm thinking is to have a workload_type pod and instead of selecting the pod name, select a pod label for port-forward.

do you think this would work?

allemp commented 2 months ago

Hello! I think that would work just fine!

hcavarsan commented 2 months ago

hey @allemp , ive implemented the new workload_type called pod, making it possible to select and forward via pod labels.

new version: https://github.com/hcavarsan/kftray/releases/tag/v0.12.0

could you please test it to see if everything is working fine?

allemp commented 2 months ago

I tested it and it works great. Thanks!