hcayless / P3-processing

1 stars 2 forks source link

Glitch on specific file: #endBlockQuote bug #43

Open jcowey opened 2 years ago

jcowey commented 2 years ago

I uploaded

https://github.com/hcayless/P3-processing/blob/main/sources/pLond_inv868_rev_prep_feb22.docx

a few minutes ago.

After the processing:

https://github.com/hcayless/P3-processing/actions/runs/1893495117

(85 seconds)

https://github.com/hcayless/P3-processing/blob/main/articles/pLond_inv868_rev_prep_feb22/pLond_inv868_rev_prep_feb22.xml

was produced

something has broken after it processed #acknowledgement.

Possibly #blockQuote #endBlockQuote caused problems. Not sure that this has actually been tested so far.

jcowey commented 2 years ago

Have another test file with #blockQuote: https://github.com/hcayless/P3-processing/blob/main/articles/Azzarello_receipts_rev_prep/Azzarello_receipts_rev_prep.xml

It is pretty clear to me that after #endBlockQuote anything that follows is cut out completely, until the next section. Here #bibliography has been picked up fine:

https://github.com/hcayless/P3-processing/blob/main/articles/Azzarello_receipts_rev_prep/Azzarello_receipts_rev_prep.xml#L109-L122

but what should have been <p xml:id="p12"> has dropped out altogether.

I added it manually to https://gitlab.ub.uni-heidelberg.de/verlag/PapyrologicalPublicationPlatform/-/blob/master/epidoc/Pylon_1_Azzarello/azzarello_receipts_rev.xml#L108

jcowey commented 2 years ago

I now suspect that the problem with the Zellmann Rohrer article

https://github.com/hcayless/P3-processing/blob/main/sources/pLond_inv868_rev_prep_feb22.docx

which produced that

https://github.com/hcayless/P3-processing/blob/main/articles/pLond_inv868_rev_prep_feb22/pLond_inv868_rev_prep_feb22.xml

suffered because #introduction followed #acknowledgement

possibly #introduction is only allowed to followed papyrological header (i.e. a table) or be part of #edition.

jcowey commented 2 years ago

With the new upload

https://github.com/hcayless/P3-processing/blob/main/sources/pLond_inv868_rev_march22.docx

(got rid of #introduction and #blockQuote with #endBlockQuote)

I get

https://github.com/hcayless/P3-processing/blob/main/articles/pLond_inv868_rev_march22/pLond_inv868_rev_march22.xml

into which I will introduce the quote section in XML

hcayless commented 2 years ago

I think I have sorted this out, but we'll need to re-run to test.