search

hcbpassos / drag_select_grid_view

A grid that supports both dragging and tapping to select its items.
BSD 2-Clause "Simplified" License
133 stars 34 forks source link

Single click selection #18

Closed denizhoxha closed 3 years ago

denizhoxha commented 3 years ago

Hi Hugo,

I had the need to enable selection of one or more items via single click so I forked your project. In case you want to merge this to master you can accept this PR.

hcbpassos commented 3 years ago

Thanks for submitting this PR!

I really like the idea, but I feel like "single click selection" doesn't actually describe what you want to achieve. The current behavior is: when long-pressing an item, trigger selection. The desired behavior is: when tapping an item, trigger selection.

What do you think about "trigger selection on tap" instead?

denizhoxha commented 3 years ago

I agree! "trigger selection on tap" is semantically correct so I will update the PR :).

hcbpassos commented 3 years ago

Looks great :)

Would would mind testing the new behavior? A single test right below this one should be fine.

hcbpassos commented 3 years ago

I'll merge this and add a test.

Thanks!