search

hcdenbakker / sepia

taxonomic classifier based on the kraken2 algorithms and more
GNU General Public License v3.0
45 stars 3 forks source link

Fix cargo clippy warnings #13

Closed Ebedthan closed 3 years ago

Ebedthan commented 3 years ago

Hi @hcdenbakker,

I believe that one core advantage of Rust is the detection of potential threats to code health at compile time. So I recommend you to follow the cargo clippy recommendation and fix the warning pointed out. So you could remove the "ignore warning" in the installation instruction. Please do it as soon as possible to let the review process go forward as I will point this issue in my review report.

hcdenbakker commented 3 years ago

Hi @Ebedthan,

Thanks! I fixed the warning that pop up at compile time now and will push this to the main branch as soon as possible. I will additionally use cargo clippy suggestions to address additional potential issues. I may not follow every suggestion of clippy; I found in the past that some suggestions make the code less performant, I will point this out in the comments.

Ebedthan commented 3 years ago

Hi @hcdenbakker, Please can you kindly let me know if you are done with fixing Clippy warnings? Although I can agree with you in some cases, cargo clippy actually points some issues that I believe should be resolved for the general health of the application. For example, Clippy points to a use of `unwrap_or` followed by a function call which is an unnecessary lazy evaluation. You will find many other warnings that I advise you to fix as I believe it will not have a negative impact on your application but moreover make your application safer.