hcengineering / platform

Huly — All-in-One Project Management Platform (alternative to Linear, Jira, Slack, Notion, Motion)
https://huly.io
Eclipse Public License 2.0
17.27k stars 1.04k forks source link

Bug: Signup > Create Workspace | Can not use "enter" key to submit my workspace name. #5221

Open chwasifjameel opened 7 months ago

chwasifjameel commented 7 months ago

Issue: After the "Signup" screen, the "Create Workspace" screen does not submit values if you hit enter.

Description: The form is being submitted with evt.Key='Enter'. form tag has its own submission which should be invalidated if evt.Key is being used to submit the form.

Submission function for reference: #https://github.com/hcengineering/platform/blob/main/plugins/login-resources/src/components/Form.svelte#L137-L145

Why Form.svelte is not giving this issue for login and signup? Possibly because those operations do not take that long and navigation happens very quickly. In case of Workspace creation, it takes a few seconds

Reference: image

Solution: We should add evt.preventDefault() on this keydown function.

Updated code:

on:keydown={(evt) => {
    if (evt.key === 'Enter' && !inAction) {
      evt.preventDefault()  
      validate($themeStore.language).then((res) => {
        if (res) {
          performAction(action)
        }
      })
    }
  }}
chwasifjameel commented 7 months ago

Please assign this to me. I have resolved this.