DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)

hcengineering / platform

Huly — All-in-One Project Management Platform (alternative to Linear, Jira, Slack, Notion, Motion)

https://huly.io

Eclipse Public License 2.0

17.55k stars 1.06k forks source link

DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted) #7092

Open gptlang opened 3 weeks ago

gptlang commented 3 weeks ago

When self hosting, SMTP isn't supported yet. The default email based login doesn't work. Login by email is just a click away but it would be easier if that could just be made default.

This change makes it such that we can simply add

LOGIN_PASSWORD_ONLY=true

to the environment to switch the defaults around.

lexiv0re commented 3 weeks ago

Hello @gptlang , thanks for your contribution!

aonnikov commented 3 weeks ago

Just an idea, can we use SES url to determine if we should use OTP login method? If we don't have email service configured, then we should not have SES url and OTP is not possible.

lexiv0re commented 3 weeks ago

@aonnikov yeah, that's a good idea. I thought about this too and it appears we don't currently have SES url in our front service config file. So we'd have to add SES_URL to the front only to check whether OTP is supported or not. Why I probably would't want to expose it right now is that with the upcoming changes in the account we may immediately have other OTP delivery methods connected to various social logins other than email (e.g. telegram) so it might become a little bit tricky then.