search

hchasestevens / avro2py

Avro codegen for Python 3.6+
MIT License
4 stars 2 forks source link

handle serializing array type #11

Closed vrsandeep closed 3 years ago

vrsandeep commented 3 years ago

Adds a converter for handling array types in schema

hchasestevens commented 3 years ago

Hi @vrsandeep , thank you for the contribution! Can you please:

  1. Bump the version in https://github.com/hchasestevens/avro2py/blob/master/avro2py/VERSION to 0.0.6
  2. Create a test file named test_utils.py in https://github.com/hchasestevens/avro2py/tree/master/tests , following the conventions established in the existing test files.
  3. Create a test demonstrating what this change is intended to fix (i.e. should not work in the version 0.0.5 of avro2py, but will work on your new branch) against canned test data ( feel free to use https://github.com/hchasestevens/avro2py/blob/master/tests/sample_schema.avsc , which has some existing array types in various messages)
  4. Create a property-based test exercising your new codepath for arbitrary cases.
vrsandeep commented 3 years ago

@hchasestevens added a property based test showing the difference of output produced by the fix and bumped the version

vrsandeep commented 3 years ago

@hchasestevens Are the changes ok? Any other concerns?

vrsandeep commented 3 years ago

@hchasestevens pinging again, if you missed the previous notification

hchasestevens commented 3 years ago

@vrsandeep Looks good to me, thanks again for submitting the fix.