hchunhui / librime-lua

Extending RIME with Lua scripts
BSD 3-Clause "New" or "Revised" License
293 stars 43 forks source link

follow up librime#806, avoid path-string conversion #310

Closed lotem closed 5 months ago

lotem commented 5 months ago

Avoid using RimeGet*Dir() from rime_api. They return native path on Windows and coding conversion is incurred.

When passing path from lua to librime class, use either rime::path object or UTF-8 encoded string.

lotem commented 5 months ago

還有一小部份 ,可否一起

These changes are in my commit. Anything else?

lotem commented 5 months ago

Changed file_name(db) to return ANSI string. PTAL

hchunhui commented 5 months ago

LGTM. Added some code to ensure it can build with librime <= 1.9.0