search

hckr / fb-post-screenshot

Firefox Web Extension to save Facebook posts as images
https://hckr.pl/fb-post-screenshot/
Mozilla Public License 2.0
20 stars 7 forks source link

Reaction icon disappears for some comments. #20

Closed martinramirezz closed 4 years ago

martinramirezz commented 5 years ago

Hi again hckr, thanks a lot for the new bug fixes and improvements. The add-on is just looking better and better every day! I'm so happy and greateful for your great work.

I finally got some free time to write about a little aesthetic issue I found last month. It has probably been there already since March, but I just noticed it recently. The thing is that sometimes the add-on seems unable to capture the little reaction icon that should appear on the bottom-right corner of a comment when you react to it. It might show that you have reacted to the comment on the bottom-left corner, but without any icon on the bottom-right corner.

To reproduce it, you just have to go any post, either from within a group or a page, like or react to all or some of the comments, take a screenshot with the add-on and then look carefully at the generated screenshot and you will see that some comments will include the icon of your reaction on the bottom-right corner and others won't.

hckr commented 5 years ago

Hi, thanks for reporting this. I honestly haven't noticed it until now and it's very weird :open_mouth:. I'll try to fix this, but first I have to find the root cause.

martinramirezz commented 5 years ago

For a moment I thought that it's just a matter of speed. I might be entirely wrong here, but I got the impression that the icon takes some time to be generated, so it gets loaded after the screenshot is taken.

hckr commented 5 years ago

Yeah, but this doesn't fit to what happens behind the scenes in the popup window (behind the blue layer with status text):

  1. Open post's permalink page.
  2. Simulate clicks on all links to expand all content.
  3. Save fragment of the page as images.

As you see, at least the reactions for comments in the first parts (of a longer post) should load – but they don't.