search

hckr / fb-post-screenshot

Firefox Web Extension to save Facebook posts as images
https://hckr.pl/fb-post-screenshot/
Mozilla Public License 2.0
20 stars 7 forks source link

Save screenshot not working for videos #22

Open orvi opened 5 years ago

orvi commented 5 years ago

How to reproduce

  1. Go the some page that contains posts with videos. for example: https://www.facebook.com/bbcnews/
  2. Find a post with a video and click save screenshot. Try for example this post

Actual Behavior

The little window is opened with the text Status: clicked 0 times, at least 0 more clicks... and nothing happen

Why it happens

The permalinks of videos are opened in Facebook Watch which have different layout then regular feed posts

How to fix

So I found out that if you add ?comment_id=1 to the post URL it will open it in the regular feed environment where the plugin can work. For example: https://www.facebook.com/bbcnews/posts/336144490663782?comment_id=1

Why I don't just push a PR

I don't have the setup to test addon and probably @hckr can fix it faster then me ;)

hckr commented 5 years ago

Hi @orvi,

Thanks for such an in-depth description and proposed solution. I'm on vacation now, that's why I haven't checked GitHub for some time. I'll fix this as soon as I have the opportunity (probably Monday or Tuesday).

orvi commented 5 years ago

No worries. Enjoy your vacation. Let me know if you have further questions :)

hckr commented 5 years ago

I've updated the addon, it should be ok now.

orvi commented 5 years ago

Confirmed as fixed. Thanks.

hckr commented 4 years ago

Unfortunately it's back to not working.