hcloud-talos / terraform-hcloud-talos

This repository contains a Terraform module for creating a Kubernetes cluster with Talos in the Hetzner Cloud.
https://registry.terraform.io/modules/hcloud-talos/talos
MIT License
65 stars 16 forks source link

feat: Adds labels to hcloud objects #25

Closed mpepping closed 4 months ago

mpepping commented 4 months ago

The labels cluster and role are added to hcloud objects. Labels can be used as selector in subsequent Terraform resources.

github-actions[bot] commented 4 months ago

Terraform-Check: ✅

🖌 Terraform Format: ✅ ``` # Outputs: # Errors: ```
⚙️ Terraform Init: ✅ ``` # Outputs: Initializing the backend... Initializing provider plugins... - Finding hashicorp/http versions matching ">= 3.4.2"... - Finding hashicorp/helm versions matching ">= 2.12.1"... - Finding gavinbunney/kubectl versions matching "1.14.0"... - Finding hashicorp/tls versions matching ">= 4.0.5"... - Finding hetznercloud/hcloud versions matching "1.47.0"... - Finding siderolabs/talos versions matching "0.5.0"... - Installing hashicorp/http v3.4.2... - Installed hashicorp/http v3.4.2 (signed by HashiCorp) - Installing hashicorp/helm v2.13.2... - Installed hashicorp/helm v2.13.2 (signed by HashiCorp) - Installing gavinbunney/kubectl v1.14.0... - Installed gavinbunney/kubectl v1.14.0 (self-signed, key ID AD64217B5ADD572F) - Installing hashicorp/tls v4.0.5... - Installed hashicorp/tls v4.0.5 (signed by HashiCorp) - Installing hetznercloud/hcloud v1.47.0... - Installed hetznercloud/hcloud v1.47.0 (signed by a HashiCorp partner, key ID 5219EACB3A77198B) - Installing siderolabs/talos v0.5.0... - Installed siderolabs/talos v0.5.0 (signed by a HashiCorp partner, key ID AF0815C7E2EC16A8) Partner and community providers are signed by their developers. If you'd like to know more about provider signing, you can read about it here: https://www.terraform.io/docs/cli/plugins/signing.html Terraform has created a lock file .terraform.lock.hcl to record the provider selections it made above. Include this file in your version control repository so that Terraform can guarantee to make the same selections by default when you run "terraform init" in the future. Terraform has been successfully initialized! You may now begin working with Terraform. Try running "terraform plan" to see any changes that are required for your infrastructure. All Terraform commands should now work. If you ever set or change modules or backend configuration for Terraform, rerun this command to reinitialize your working directory. If you forget, other commands will detect it and remind you to do so if necessary. # Errors: ```
🤖 Terraform Validate: ✅ ``` # Outputs: Success! The configuration is valid. # Errors: ```
mrclrchtr commented 4 months ago

:tada: This PR is included in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

mrclrchtr commented 4 months ago

@mpepping Just out of interest, what would be a possible scenario?

mpepping commented 4 months ago

Thanks for merging, @mrclrchtr! I'm using the Label selector functionality from the hcloud provider to select objects that I want to use with a different TF provider. In my case for creating DNS records on a third-party service.

mrclrchtr commented 4 months ago

Ah okay, that sounds interesting. Thanks.