soc-pe-bot
commented
1 year ago Team's Response
As mentioned by tester, these seller issues are a duplicate of the buyer issues
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Phone number takes values that are not 8 digits long
Phone numbers that are shorter or longer than 8 digits are accepted. Might be a good restriction to add, as it will help the user realise if they accidentally skipped or added a digit when adding a new person.
[original: nus-cs2103-AY2324S1/pe-interim#4463] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Hi I am the dev responsible for the field validation rework, and hence I am responsible for this issue. Thanks for the report, however I don't think this is something that we should implement. In many countries 8-digit numbers are not the norm (e.g US, India, Malaysia), and given that our product is not only targeted at Singaporeans, this would be a bad idea.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: It is not just a duplicate of 1 issue. This bug was created to prevent unnecessary duplications as a lot of the issues that plagued the buyers also affected the sellers and by mentioning it as such was to help point out the issues without repeating myself, namely 11, 10, 9, 7, 4, 3, 2
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** See comments for original bugs.
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
A lot of the seller issues seem to be a repeat of the buyer issues. So might want to take a look at those as well. I have attached the buyer issues below.