search

hcs1203 / pe

0 stars 0 forks source link

Phone number takes values that are not 8 digits long #2

Open hcs1203 opened 1 year ago

hcs1203 commented 1 year ago

Phone numbers that are shorter or longer than 8 digits are accepted. Might be a good restriction to add, as it will help the user realise if they accidentally skipped or added a digit when adding a new person.

Screenshot 2023-11-17 at 4.15.12 PM.png

Screenshot 2023-11-17 at 4.18.36 PM.png

soc-pe-bot commented 1 year ago

Team's Response

Hi I am the dev responsible for the field validation rework, and hence I am responsible for this issue. Thanks for the report, however I don't think this is something that we should implement. In many countries 8-digit numbers are not the norm (e.g US, India, Malaysia), and given that our product is not only targeted at Singaporeans, this would be a bad idea.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Generally property apps are location/country based. Therefore I believe that it is still good to add a phone number check as the buyers and sellers are likely to come from the same country. Should the app be launched in different countries, then the check can be modified accordingly for the respective versions.