hcs1203 / pe

0 stars 0 forks source link

Phone number validity check #4

Open hcs1203 opened 1 year ago

hcs1203 commented 1 year ago

A check could be added if the phone number starts with 8, 9 or 6. This will add a layer of safety in ensuring that the number typed is right.

Screenshot 2023-11-17 at 4.29.24 PM.png

nus-pe-bot commented 1 year ago

Team's Response

Hi, I was the developer responsible for changing the restrictiveness of field inputs. Thank you for the report, I am always thankful for feedback. However this is completely intentional since for example, many international numbers start with different digits, not to mention area codes. Furthermore if you wanted to input two numbers this would also cause issues. Quoting from the website:

Example 1: While your software allows only one phone number in input values, a user might want to input 1234 5678 (HP) 1111-3333 (Office) -- blocking that input might not add any value but allowing it does.

Hence we do not do these checks. However our warning system does provide some protection by informing users if we think the formatting might have some mistakes, so that users do not unintentionally misinput data. See the appendix on fields for more info. Hence we have chosen to reject this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I would like to know how your team handles the multiple number input and phone number feature in general. Should this just be a bookkeeping app with the phone number having to be manually copied and not a hyper-link, the current format may work with minimal issues. However, for any subsequent development, there may be issues.

Under the guise of allowing different numbers, I can add any set of letters and it is accepted as long as the string has 1 number (32). Also I can break any of the rules that are stated, and am still allowed to insert the values.

Screenshot 2023-11-23 at 1.37.16 AM.png

Screenshot 2023-11-23 at 1.39.30 AM.png