nus-se-bot
commented
1 year ago Team's Response
We definitely agree that the undo and redo command can show the past commands that are being undone/redone. However, we feel that it is not in scope as this augmentation would require us to store the CommandResult into every state of the VersionedAddressBook, and rectifying it is less important (based on the value/effort considerations) than the work that has been done already. Moreover, the user would commonly use the undo or redo command when they make mistakes, so they would have known what commands went wrong. In addition, many applications that we use today also do not indicate to the user what has been undone/redone (such as word docs/excel), and the user is left to see it on his own, which is why we did not feel like it was too important to implement this in our feature.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: I would agree with your reasoning if only the last command can be undone. I think it becomes more of an issue when multiple commands can be undone. It is hard for the user to remember the last 5 commands or when to stop, say they realised that they made a series of carry-over mistakes. As for the undo and redo feature in word or docs, it is possible to restore the last saved version, thus it is still possible for the user to restore that version and start from there. This is not the case in your app as the user would have to analyse the app manually to figure exactly what state the app is in.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** For the given issue, I believe that this is not a rare issue but not high enough that makes the app unusable. 
A message stating what was undone will be helpful, especially since the person may not remember exactly what the previous/next command refers to, especially when undo allows multiple consecutive runs.