hcs1203 / pe

0 stars 0 forks source link

Undo feature should only reverse 1 command #8

Open hcs1203 opened 1 year ago

hcs1203 commented 1 year ago

It will be easier to check if the outcome of the command if the undo command only works on one command. It will save steps if the undo command in the example in the video only undid the delete and still showed the filtered step.


video:https://raw.githubusercontent.com/hcs1203/pe/main/files/5ec2e8e1-54ae-4774-8ed7-2dd0d9da6617.mov

nus-se-script commented 1 year ago

Team's Response

We currently implemented the undo feature to show the full list every time it is executed, to accommodate for cases where the undo reverts changes that are not shown in the filtered list.

For instance:

To show the restoration of "Alex Yeoh" in the original list, the undo command displays the original list instead of maintaining the filter.

At the same time, your suggestion is very accurate, and it would definitely be much better if changes to a filtered list when undone, still maintain the filtered view of the list. Perhaps in future iterations of our application, this can be an enhancement to the undo feature, where undo remembers whether a change was made within a filtered list or outside of the filtered list, and shows the appropriate list correspondingly!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]