search

hcts-hra / ziziphus

10 stars 2 forks source link

Agent: Non-VIAF-value not saved, "broken" entry not deletable #171

Closed TonyBuchwald closed 10 years ago

TonyBuchwald commented 10 years ago

Adding an agent that is not found in VIAF causes:

  1. The entered value is not saved.
  2. Role and Type are saved.
  3. The "empty value" entry can not be deleted.

--> Several broken agents keep being displayed.

Ziziphus version: 0.29.0

Link to record: http://kjc-sv016.kjc.uni-heidelberg.de:8080/exist/apps/tamboti/modules/search/index.html?search-field=ID&value=w_8412dc6d-5752-4e6b-b1e8-62a73c33bc25 2014-07-02_16-24-48 2014-07-02_16-25-35

zwobit commented 10 years ago
  1. Should we allow to enter "freetext" entries here? Shouldn't this trigger the 'to be implemented' "Add new repository entry" dialog/form?
  2. Should we allow this till we have the dialog/form mentioned above?
TonyBuchwald commented 10 years ago
  1. Deleting should be allowed. It seems to be bugged in general as I also cannot delete a VIAF-confirmed agent entry:

http://kjc-sv016.kjc.uni-heidelberg.de:8080/exist/apps/tamboti/modules/search/index.html?search-field=ID&value=w_88fd8e4a-de19-4acd-a1ad-f0a902ade68c

edit: Trying to save changes after deleting the broken agent also causes Ziziphus to stop working altogether. After clicking "Save" i cannot edit anything else without refreshing Ziziphus.

MatthiasArnold commented 10 years ago

1) we should not allow free text. entering a term in a controlled field (e.g. agent name, or subject term) that does not have a controlled value (i.e. is neither in the available in the local repository nor in the external thesauri, VIAF for an agent) a workflow to create a new entry in the local repository has to be triggered.

2) @role and @type should not be saved without a value within

3) removing agents should work, even if the content of the agent is incomplete

zwobit commented 10 years ago

Saving of empty AgentSet #172 is not working, rest should be fixed.

jodevelops commented 10 years ago

works fine

for: "a workflow to create a new entry in the local repository has to be triggered", there will be more feature requests soon.

TonyBuchwald commented 10 years ago

Deleting an agent still does not work for me in /resources/users/heraeditor/HERA_Single/Tony_Buchwald Same behavior: Ziziphus freezes after clicking "save" when deleting an agent.

jodevelops commented 10 years ago

on tamboti-test, in firefox, it works for me.

I am here: http://kjc-ws2.kjc.uni-heidelberg.de:8650/exist/apps/ziziphus/record.html?id=w_c1e67918-048a-544a-9579-f786b39c960c&workdir=/db/resources/commons/Priya_Paul_Collection/

TonyBuchwald commented 10 years ago

Sorry I didn't mention it: I tried it on both test and live servers, ws2 and sv016.

http://kjc-ws2.kjc.uni-heidelberg.de:8650/exist/apps/ziziphus/record.html?id=w_993aa6dc-8841-4cdd-9c5e-5e48701f7439&workdir=/db/resources/users/heraeditor/HERA_Single/Tony_Buchwald/&imagepath=/db/resources/users/heraeditor/HERA_Single/Tony_Buchwald/VRA_images/i_cbbcfc8f-5297-4ec4-bbcc-7383f775a663.xml

zwobit commented 10 years ago

Ok just to clarify. You mean saving of an empty AgentSet?

TonyBuchwald commented 10 years ago

No, deleting of a regular AgentSet (I used "Marx, Karl" for my tests).

jodevelops commented 10 years ago

alright yes: deleting the last entry in an agentSet causes Z to freeze.

zwobit commented 10 years ago

Okay then i will close in favor of #172. That at least what i meant with that ticket.