search

hcts-hra / ziziphus

10 stars 2 forks source link

images missing #260

Closed jodevelops closed 8 years ago

jodevelops commented 9 years ago

images are missing in ziziphus 0.40 (they are not loaded into Z.)

Also, thumbnails of related images are missing

zwobit commented 9 years ago

Where? User-Collections? PPCOL seems to work.

jodevelops commented 9 years ago

on ws2, i cannot see the images in Z., not in PPColl, nor in my own collections - they are visible in tamboti, though.

MatthiasArnold commented 9 years ago

problem confirmed: images show in z on live server (v0.35), but not on test server (v0.40). tested on these collections (test server):

zwobit commented 9 years ago

Ah, it only happens if you call Z from T.

zwobit commented 9 years ago

Should be fixed on ws2 an in T trunk.

jodevelops commented 9 years ago

reopened: related images (thumbnails) in relationSet are still missing, Image & Work record

MatthiasArnold commented 9 years ago

confirmed: thumbs in relationSet (work AND image) still missing image

SimonGruening commented 9 years ago

Related but closed issue was #216 Also related: #83 , #84 , #217

MatthiasArnold commented 9 years ago

HALF of the problem is solved: in v0.41 thumbnails appear in WORK relation. :) however, the links are still broken in IMAGE relation. this is the case in both, personal collections (e.g. "matzes images"), and commons collections (e.g. "Priya_Paul_Collection").

Example (ppcoll): 28-05-2015 17-28-25

zwobit commented 9 years ago

Right now i am not 100% sure what we should show for the imagerecord. Right now i show the "pref" (if present) image record from the work record or the first one. Is this okay?

jodevelops commented 9 years ago

yes, sounds very plausible to me. And when 1.) the first entry in relationSet is NOT an image record ("imageIs") and 2.) when there is NO pref=true setting on any related image (type "imageIs") the entries have to be skipped until there is one that fits the conditions.

Some of the images were not shown, because - in the relationSet - there was some other entry ABOVE the imageIs and the script took this first element in relationSet as "pseudo imageIs", and of course it did not work, because the relation was not necessarily an actual image (but maybe another work record).

jodevelops commented 8 years ago

all fine in WORK record.

Did we want an image thumbnail in the "relationSet" of the image record as well?

zwobit commented 8 years ago

ImageRecord related image type = "imageOf"

zwobit commented 8 years ago

done. If relid is a imagerecord id this is used, if it is a workrecord id first pref + ImageIs or first ImagesIs is used