hcts-hra / ziziphus

10 stars 2 forks source link

date type=life automatic for geographic / corporate names? #373

Open jodevelops opened 8 years ago

jodevelops commented 8 years ago

there seems to be an automatism for all agent-names: it adds "life" as a type for date values, although these dates are not necessarily given (nor do they make sense) in the case of geographic names / corporate names, etc.

Here is an example with corporate name:

01-12-2015 16-41-54

however, as the NAME TYPE is always correct and entered automatically:

Can or rather: should [feature] there be such a rule, that the rest of the data values is being made dependent on that name type?

That means: filtering the process of data accumulation by agent-name-TYPE?

In this example, this would mean, that ONLY for PERSONAL names, date-type="life" is set automatically, the rest of the name types will not trigger any more data fill.

zwobit commented 8 years ago

mmh, this should only happen if the name is of type personal ...

zwobit commented 8 years ago

was "life" already set?

jodevelops commented 8 years ago

In that one case, when the existing value is CHANGED from a personal one to a corporate one, the attribute "life" will stay in the record, but if it is a new entry (type: corporate), everything is fine.

Can the autofill function include clearing the date type field before filling it? In the case of corporate entries, this would imo solve the problem of unwanted remaining data fragments from older entries.

SimonGruening commented 8 years ago

I'm not sure, if it makes sense that this is set automatically for personal names. There are many cases where VIAF doesn't give any life-and-death-dates - e.g. for all "unknown [nationality]" entries. I think "life" shouldn't be set automatically, if there are no life-and-death-dates.