search

hcwong / pe

0 stars 0 forks source link

Customer Index is affected by find #4

Open hcwong opened 5 years ago

hcwong commented 5 years ago

To reproduce this bug, try using find on any of the list

The index is not no longer the index it was without the filter caused by find.

This also means that after find, you can no longer edit any objects which have not been found by find, which can be quite confusing

The user docs alludes to this, but it quite confusing that you the numbers suddenly change after find

This works

Screen Shot 2019-11-15 at 4.49.41 PM.png

Now this does not because the index is no longer 9 after find

Screen Shot 2019-11-15 at 4.50.35 PM.png

nus-pe-bot commented 4 years ago

Team's Response

Intended behaviour:

According to our UG:

5.2.3. Delete a customer: delete-c

Deletes a customer in SML. Note that deleting a customer will also delete the orders and schedules associated with the customer.

Format: delete-c INDEX

Deletes the customer at the specified INDEX.

The index refers to the index number shown in the displayed customer list.

We wanted to allow the user to delete whatever that was displayed on the list. To us, it doesn't make sense to delete something that you cannot see as it is not intuitive for the user to do so.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]