search

hd-zero / hdzero-goggle

MIT License
263 stars 76 forks source link

Menu highlight should change when in sub-menu #363

Closed evilC closed 12 months ago

evilC commented 1 year ago

When on the main menu, when you roll the wheel, the selected entry in the main menu is highlighted grey to indicate that the current sub-menu is selected. When you click to enter that sub-menu, the highlight of the main menu remains grey and the sub-menu also has a highlight, which is also grey. I feel that the main menu highlight should change in some way (Maybe turn green?) to indicate this state.

All too frequently I find myself accidentally long pressing once too many times and exiting to the FPV view, and I think this is why

pfeerick commented 1 year ago

I agree... there needs to be some visual indication that you are in the subpage, and not interacting with the sidebar menu still. It could even be as simple as the red arrow NOT being shown as you scroll, and only being visible once you press on a menu item.

Master92 commented 1 year ago

I fiddled a little with the menu design and came up with the following proposal:

screenshot_menu_highlight

It changes the highlighting color to a lighter grey and removes the red arrow as soon as you enter a submenu. What do you think about that?

pfeerick commented 1 year ago

I tend to think it makes sense for the arrow to be not shown until you enter the submenu/page, but I guess using it will tell if that makes sense or not. PR when? 🤣

Master92 commented 1 year ago

I see what you mean and thought the same. However the red arrow unfortunately doesn't have an alpha channel so when I tried to do that, there was an awkward grey-ish box around it. I think, we'd need to update the resource then but unfortunately, the original icon image is nowhere to be found 😣

You mean something like this?

screenshot_menu_highlight_v2

Do you really think I should open a PR? I mean, this pretty significantly impacts the UX...

pfeerick commented 1 year ago

Ouch, yeah, that can make things awkward!

Yes, that was the idea... I.e. the arrow reinforces that input is now in the submenu/page. Which is what confused me right from the start when it followed the highlight.

And sure, if you've coded something up, summit it... Others can try it and should lead to some more discussion. :)

On Mon, 6 Nov 2023, 9:47 pm Nils H., @.***> wrote:

I see what you mean and thought the same. However the red arrow unfortunately doesn't have an alpha channel so when I tried to do that, there was an awkward grey-ish box around it. I think, we'd need to update the resource then but unfortunately, the original icon image is nowhere to be found 😣

You mean something like this?

[image: screenshot_menu_highlight_v2] https://user-images.githubusercontent.com/8737970/280696045-86b838b4-34f9-419b-b616-d50d009574ae.png

Do you really think I should open a PR? I mean, this pretty significantly impacts the UX...

— Reply to this email directly, view it on GitHub https://github.com/hd-zero/hdzero-goggle/issues/363#issuecomment-1794645017, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KOVA7FKA2JVUNDLIS3YDDE4BAVCNFSM6AAAAAA63GE3CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGY2DKMBRG4 . You are receiving this because you commented.Message ID: @.***>