search

hd-zero / hdzero-goggle

MIT License
263 stars 76 forks source link

Add cpp guards and convert to #pragma once #366

Closed Master92 closed 1 year ago

Master92 commented 1 year ago

This is only a cosmetic change and shouldn't make the software behave any different to as it was before. Binary diff says:

$ diff -s HDZGOGGLE_main HDZGOGGLE_new
Files HDZGOGGLE_main and HDZGOGGLE_new are identical

The only reason for this PR is that you effectively can't write any cpp code right now without considering which include has to declared extern "C" and which doesn't.

SumolX commented 1 year ago

I would also recommend that we also standardize the include guard to use #pragma once for all files.

Master92 commented 1 year ago

I would also recommend that we also standardize the include guard to use #pragma once for all files.

Totally agreed! I'll update this PR in the next few hours 👍

ligenxxxx commented 1 year ago

Please solve the conflicts.

Master92 commented 1 year ago

Force-pushed due to rebase to current main HEAD resolving the merge-conflict.