hd-zero / hdzero-goggle

MIT License
263 stars 76 forks source link

Adding Confirmation Dialog On Pressing Delete in Playback Menu #443

Closed wxyzsupermod closed 2 weeks ago

wxyzsupermod commented 2 months ago

This PR is to add a dialog confirmation before deleting user data. I accidentally deleted a file while trying to hot it at a race and deleted my best run of the day. I don't want to have that happen to others so I have added this dialog. image

sanderpuh commented 1 month ago

Nice quality of life feature!

Suggestion on the displayed text from my side (remove capital D and add questionmark): Are you sure you want to Delete the file -> Are you sure you want to delete the file?

Also, what should I click (or press) and what is the function key? Click to continue. Press function to exit.

Perhaps something like the following example: Press again to delete, scroll to cancel.

Or similar, the above example confirms to the user which button to press (or scroll).

wxyzsupermod commented 1 month ago

Nice quality of life feature!

Suggestion on the displayed text from my side (remove capital D and add questionmark): Are you sure you want to Delete the file -> Are you sure you want to delete the file? Delete was capitalized for emphasis I'm going to make it all caps for DELETE.

Also, what should I click (or press) and what is the function key? Click to continue. Press function to exit. The function key is the term for the right button on the goggles most should know what it is

Perhaps something like the following example: Press again to delete, scroll to cancel.

Or similar, the above example confirms to the user which button to press (or scroll).

I now have click right button(function), or scroll to cancel. Only clicking center of scroll wheel will delete the file. I wanted it to be right button to cancel as the user enters deletion with that button so if they hold click it and mindlessly click the same button again it cancels only by clicking with the other hand do we delete the file.

image