hdavid16 / DisjunctiveProgramming.jl

A JuMP extension for Generalized Disjunctive Programming
MIT License
27 stars 3 forks source link

Refactor Logical Constraints to use `:=` #91

Closed pulsipher closed 11 months ago

pulsipher commented 11 months ago

Closes #83. I also improved the testing coverage a bit.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (04334c9) 98.84% compared to head (da709c7) 99.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #91 +/- ## ========================================== + Coverage 98.84% 99.89% +1.05% ========================================== Files 10 10 Lines 952 963 +11 ========================================== + Hits 941 962 +21 + Misses 11 1 -10 ``` | [Files](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez) | Coverage Δ | | |---|---|---| | [src/constraints.jl](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez#diff-c3JjL2NvbnN0cmFpbnRzLmps) | `100.00% <100.00%> (+1.16%)` | :arrow_up: | | [src/datatypes.jl](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez#diff-c3JjL2RhdGF0eXBlcy5qbA==) | `100.00% <ø> (ø)` | | | [src/macros.jl](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez#diff-c3JjL21hY3Jvcy5qbA==) | `100.00% <100.00%> (+3.10%)` | :arrow_up: | | [src/reformulate.jl](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez#diff-c3JjL3JlZm9ybXVsYXRlLmps) | `100.00% <100.00%> (ø)` | | | [src/variables.jl](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez#diff-c3JjL3ZhcmlhYmxlcy5qbA==) | `100.00% <ø> (+1.40%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/hdavid16/DisjunctiveProgramming.jl/pull/91/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hector+Perez)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.