hdb / baywatch

TUI for TPB + Peerflix + Transmission
MIT License
6 stars 1 forks source link

Messes up already installed Textual 0.51.0 #1

Open gvanem opened 4 months ago

gvanem commented 4 months ago

Prior to installing this package I had Textual version 0.51.0 installed and working OK. Cloning, building and installing this (using pip install -e .. Correct?), caused all Textual examples to fail. E.g. running py -3 examples/calculator.py:

Traceback (most recent call last):
  File "F:\gv\Python310\Lib\site-packages\Textual-Github\examples\calculator.py", line 11, in <module>
    from textual import events, on
ImportError: cannot import name 'on' from 'textual' (F:\gv\Python310\lib\site-packages\textual\__init__.py)

I assume it's this line: https://github.com/hdb/baywatch/blob/747d9b2ed1f96a60ce27c612710382990307ace8/pyproject.toml#L23 that caused it.

From the above pip install -e ., I saw textual-0.1.18 textual-inputs-0.2.6 got installed. I do not know much about pip, but why not "textual >=0.1.17"?

BTW. I'm on Win-10 Home, 22H2 (OS-build 19045.4046).

hdb commented 2 months ago

I would recommend installing baywatch to a virtual environment so that it doesn't mess with your existing textual installation. I built this using an earlier version of textual before there was a stable API so I think it is likely not compatible with the latest version of textual.

gvanem commented 2 months ago

@hdb Okay, But I absolutely loath virt-envs. It's very easy (for me) to mess up some vital detail. So could it be < 0.1.17 and >=0.1.17 compatible?