Add getBestMove and FirstBestAdmissibleTabuSearch

hdbeukel / james-core

Core module of the JAMES framework

Apache License 2.0

6 stars 5 forks source link

Add getBestMove and FirstBestAdmissibleTabuSearch #39

Closed huanfachen closed 7 years ago

huanfachen commented 7 years ago

Add a new getBestMove to NeighbourhoodSearch() with a parameter boolean acceptFirstImprovement. Add FirstBestAdmissibleTabuSearch.java

coveralls commented 7 years ago

Coverage decreased (-2.08%) to 95.095% when pulling 1c9e3b8b3d6c0cb9d517f4dd3d5564ec23cad7c7 on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:master.

coveralls commented 7 years ago

Coverage decreased (-2.1%) to 95.095% when pulling e06489bed6a6ec09d32731bc1049efd71d458f4d on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 96.555% when pulling a25b183a3878f1cfb8e37c56e5f24a252bcf477e on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 96.555% when pulling df1fe558d3f873e5d33dc35cd4c83a3a4c90bf4a on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

hdbeukel commented 7 years ago

Please remove the following files and folders (IntelliJ/Eclipse settings) and include them in .gitignore to avoid that they are added in the future:

.classpath
.project
.settings
james-core.iml (add *.iml to .gitignore)
.idea

Also see my other comments.

hdbeukel commented 7 years ago

You have several compiler warnings in your code. See https://travis-ci.org/hdbeukel/james-core/builds/238702467?utm_source=github_status&utm_medium=notification. Please fix.

hdbeukel commented 7 years ago

The undesired files listed above are also still present.

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 97.146% when pulling 5d564cb959156a4200050f7fff1ce0b9efbdf685 on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 97.096% when pulling 9eaf5c4ffd50f579c196f6b6c475742d5793c3ee on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

hdbeukel commented 7 years ago

Tests fail now because you have deleted the file pom.xml (alongside the undesired files).

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 97.146% when pulling 37e899e9798ea431d2db346399184541594ea816 on huanfachen:tabuSearch/add_variant into f6bfd50ac978d1d392ab6bf8cefccfad712ff077 on hdbeukel:tabuvariant.

hdbeukel commented 7 years ago

Thanks for the fix. I will get back to this next week and merge your pull request (no time this week).

hdbeukel commented 7 years ago

I will probably make some more changes (e.g. Javadocs). If you want you can then pull them back into your fork. I will send you a pull request.