search

hdc-arizona / GardenMockups

Some mockups for tables and maps for the GardenRoots data
0 stars 0 forks source link

Add download data from table + dynamic map colors #1

Closed TT1603 closed 3 years ago

TT1603 commented 3 years ago

Thank you for the feedback! I had updated the code so you can check if it is ready for merging now.

kisaacs commented 3 years ago

Looks like this is good to go! Please re-base on master and resolve conflicts so I can merge.

kisaacs commented 3 years ago

I tried testing this out and I'm getting a white map. No colors are showing up. I think it might be an incorrect calling of getColorMapping in populateMap in viewmodel.js. It should be: this.model.getColorMapping(this.colors, key).

Also there's a small bug when the max value is given, because Math.floor will return 8 which is out-of-bounds of the colors array.