search

hddm-devs / hddm

HDDM is a python module that implements Hierarchical Bayesian parameter estimation of Drift Diffusion Models (via PyMC).
http://ski.clps.brown.edu/hddm_docs/
Other
261 stars 117 forks source link

fix all tutorial to reflect breaking changing from 0.9.9 #105

Open AlexanderFengler opened 1 year ago

AlexanderFengler commented 1 year ago

There are seemingly some tutorials which still have calls to HDDM without including the 'include' argument.

zenkavi commented 1 year ago

Hi there,

Working through the LAN tutorial I ran into some other issues as well.

Some were plotting issues which were easy enough to fix by adding hist_bottom = 0 but to get Section 6: Stim Coding and Section 7: Model Recovery to work I had to change some other things too. For section 6 this meant making sure all arguments were named and not positional. For section 7 it meant to change the model name weibull to weibull_cdf in model_config.py and torch_config.py. With these changes the output seemed to match the tutorial but I'm not entirely sure if this was appropriate.

You can review my edits here https://github.com/hddm-devs/hddm/commit/b22d489490f53bb7aaeac0423f88dd75025ea088

Lmk if this makes sense and if you'd like a PR.