search

hddm-devs / hddm

HDDM is a python module that implements Hierarchical Bayesian parameter estimation of Drift Diffusion Models (via PyMC).
http://ski.clps.brown.edu/hddm_docs/
Other
260 stars 117 forks source link

Reset q-values #52

Closed madslupe closed 4 years ago

madslupe commented 4 years ago

Reset q-values between conditions in hddm.HDDMrl and hddm.Hrl

madslupe commented 4 years ago

Update to ensure q-values are reset to q-init between conditions, and prevent type-error by forcing response to be int, feedback to be float and split_by to be int

twiecki commented 4 years ago

LGTM, thanks @madslupe . How critical is this bug, should we cut a new release?

madslupe commented 4 years ago

I think maybe a new release is warranted, as it could affect estimates.

On Mon, Jan 20, 2020 at 9:26 AM Thomas Wiecki notifications@github.com wrote:

Merged #52 https://github.com/hddm-devs/hddm/pull/52 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hddm-devs/hddm/pull/52?email_source=notifications&email_token=AA2PQIN55KUDGTSFJKA66SLQ6VN2HA5CNFSM4JPCQB2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWCGIBBY#event-2961997959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2PQIOFRIYT37BPCN3HVCLQ6VN2HANCNFSM4JPCQB2A .

-- Best, Mads