search

hddm-devs / hddm

HDDM is a python module that implements Hierarchical Bayesian parameter estimation of Drift Diffusion Models (via PyMC).
http://ski.clps.brown.edu/hddm_docs/
Other
268 stars 119 forks source link

Regressor for RLDDM #58

Closed madslupe closed 4 years ago

madslupe commented 4 years ago

Created a new class called HDDMrlRegressor that allows estimating instrumental learning with the RLDDM while also estimating the impact of continuous regressors. It builds on the HDDMRegressor, but adds a learning rate parameter and takes as input feedback on choices. A potential issue is that I also included alpha as a parameter for the normal HDDMRegressor, because I create alpha in base.py. Ideally this would be created within the HDDMrlRegressor class, but I didn't get that working when also letting regressors impact alpha.

madslupe commented 4 years ago

Thomas, you think this is ready for merging?

twiecki commented 4 years ago

Nice one!

madslupe commented 4 years ago

Thanks! Should I update to 0.7.6 as well?

twiecki commented 4 years ago

pypi? yes!

On Wed, Apr 15, 2020 at 3:56 PM madslupe notifications@github.com wrote:

Thanks! Should I update to 0.7.6 as well?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/hddm-devs/hddm/pull/58#issuecomment-614055993, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFETGFX27S7VBWIOLCB7LTRMW4KDANCNFSM4LSWN32A .