search

hdevalence / ed25519consensus

Go Ed25519 suitable for use in consensus-critical contexts.
BSD 3-Clause "New" or "Revised" License
50 stars 11 forks source link

add signing functionality #8

Closed tac0turtle closed 3 years ago

tac0turtle commented 3 years ago

This pr adds signing functionality using filippio's library. Not sure if we want to add other functionality as well until https://go-review.googlesource.com/c/go/+/276272 is merged and released?

hdevalence commented 3 years ago

Originally the package didn't include signing because the ZIP215 rules don't affect honest signers either way, and signing is already provided by the language package.

Am I understanding the context correctly that

  1. the motivation for adding signing functionality is to pick up the faster curve implementation used by this library but not used by the standard library;
  2. there is some possibility (the PR you linked) that the standard library would pick up that curve implementation?
tac0turtle commented 3 years ago

on second thought, this isnt a big need for us. Will close it