hdgarrood / purescript-sequences

Various efficient-ish sequence types for PureScript.
http://pursuit.purescript.org/packages/purescript-sequences
MIT License
45 stars 22 forks source link

0.9.1 Compatibility #22

Closed bkonkle closed 7 years ago

bkonkle commented 8 years ago

0.9.1 has a problem with FingerTree. 😅

[1/1 ErrorParsingModule] bower_components/purescript-sequences/src/Data/FingerTree.purs:96:10

  96    foldr (-<) z (Node2 _ a b)   = a -< (b -< z)

  Unable to parse module:
  unexpected -<
  expecting binder

Is it incorrectly interpreting this as a record update and then rejecting it because of the deprecated syntax?

Thanks for any help you can provide!

hdgarrood commented 8 years ago

Not quite, the problem is that operators must be declared as aliases, but here I'm trying to bind one by calling it ‘-<‘ without using an alias. I'd fix it just by calling it f instead.

bkonkle commented 8 years ago

Oh, that makes total sense! I didn't realize that by using them in pattern matching it was actually introducing them to the local scope. I'll send a PR your way this (US) morning. 👍

bkonkle commented 8 years ago

Okay, looks like the following dependencies need to be updated as well:

paulyoung commented 8 years ago

I think the latest on this is:

kika commented 8 years ago

purescript-node-fs is good to go, 1.0.0 was released today.

bkonkle commented 8 years ago

Currently still blocked by purescript-node-readline -> purescript-benchotron.

hdgarrood commented 7 years ago

Fixed in #26 (kind of, we skipped over 0.9.x in the end).