hdgarrood / redmine_release_notes

A plugin to add release notes to Redmine
GNU General Public License v3.0
73 stars 47 forks source link

Make plugin searchable #131

Open popy2k14 opened 6 years ago

popy2k14 commented 6 years ago

Hey guys, i was running redmine 2.5.2 stable with the 1.3.1 release notes plugin and inserted:

Redmine::Search.map do |search| search.register :ReleaseNotes end

at the end of init.rb. With the versions above an this change all contents of the plugin (release notes) was searchable in redmine!

Sadly after a update to Redmine 3.4.3-stable and using the current master branch with my change from above, redmine crashes when searching anything. Here are the log:

NoMethodError (undefined method search_result_ranks_and_ids' for ReleaseNote(id: integer, issue_id: integer, text: text):Class): lib/redmine/search.rb:127:inblock in load_result_ids' lib/redmine/search.rb:125:in each' lib/redmine/search.rb:125:inload_result_ids' lib/redmine/search.rb:115:in block in load_result_ids_from_cache' lib/redmine/search.rb:114:inload_result_ids_from_cache' lib/redmine/search.rb:99:in result_ids' lib/redmine/search.rb:70:inresult_count' app/controllers/search_controller.rb:75:in index' lib/redmine/sudo_mode.rb:63:insudo_mode'

I am not so deep in ruby and redmine development to solve this by myself. From my knowledge, the method "def search_result_ranks_and_ids" is missing in the plugin and redmine wants to call this -> hence, something changed in the redmine search code.

Can please anybody with more knowledge give me some hints? Would be really nice if we can search the release notes data again.

thx Tobias