Closed dipanm closed 11 years ago
Also, it would be nice if your commits had your name and email on them. Or at least GitHub username, so that we can look back in the logs and see who made which changes. https://help.github.com/articles/set-up-git tells you how
OK, things looks good now. I have added a TODO list in the check in list. Few are still the debates so please think about that. I will fix the balance stuff and make a proper stuff. I have done good testing as far as stats are concerned.
Please provide feedback.
The balance stuff?
This looks great so far, so thank you.
Re 6 on the TODO list, since the issues aren't displayed by default after the page loads, I think that's the right approach. It might also be worth having a link to an the issues list with the appropriate filters set, so that it can be bookmarked/saved as a custom query? Re 7, I'm not sure. I'd have to play with both types in order to make a decision.
Re 8, that could be done with AJAX without significant internal changes, and I think it could work quite well.
Here things looks good now. Here is the status:
Apart from this, I have done some clean ups. Please finalize this and take this if seems perfect; Please give feedback for anything that needs to be fixed..
Awesome :)
Could you open a separate issue for your point 8? Could you also explain it a bit more -- I'm not quite sure what you mean.
Re 1, are you happy to do that, or shall I?
I'm happy with how the code looks; all that's left (aside from the above) is for me to try out your changes and see how they look from the user's point of view.
I have updated the tracker query formation as you suggested. You are right that jQuery would be useful, but I didn't knew how to add dependencies in the redmine plugin. If you can help we can do this.
I am out of idea on point 1 right now - so I would like you to pull this out.
Regarding point 8 i meant that, should clicking "Generate .." would expand a DIV below or will it be a new page? I am good either way. I thought that may be more difficult to make it expandable like the dashboard because it needs to be from a completely different controller. Anyway, i think it is best to deal with that as a separate issue.
I now submit this - so please take over and bring it to fruition.
Cool, ok. Thanks again :)
Incidentally Redmine includes jQuery, so it's safe to assume it's already there.
Merged into feature branch rearrange-gui for further work until this is ready for master.
This is a first check-in take a look at the patch, it's a full new functionality and also provide me code feedback.
We need to discuss about finalizing the stuff.
Here are todo/open discussion:
Any feedback would be welcome.