search

hdgarrood / redmine_release_notes

A plugin to add release notes to Redmine
GNU General Public License v3.0
73 stars 46 forks source link

Fix release notes preview #81

Open hdgarrood opened 11 years ago

hdgarrood commented 11 years ago

... which seems to be broken in 2.3.1 at least, because it's doing a PUT rather than a GET.

hdgarrood commented 11 years ago

Also broken in 2.2.4 and 2.1.5. :'(

dipanm commented 11 years ago

This is a very bad news. I was just thinking to migrate to 2.3! :(

hdgarrood commented 11 years ago

Does it work for you currently? Which version are you on?

I think it's a tiny javascript fix -- the request method just needs to be GET rather than PUT, I think.

dipanm commented 11 years ago

It works for me in 2.2.3!

hdgarrood commented 11 years ago

Ah I see. Maybe it's worth looking through the roadmap for 2.2.4 then, to see where this change was made.

It's a minor problem, really; it's just the preview while configuring release notes templates. You can get by without it, by trying out changes with a real version.

hdgarrood commented 11 years ago

Since custom fields may now be used in release notes, I think the preview should work with real versions rather than pretend ones.

dipanm commented 11 years ago

Oh ok - earlier I thought this is related to generate release note page. I think you are referring to "Preview with a sample version" under the configuration page. Yes, that doesn't work for me in 2.2.3. My earlier comment was wrong.

What is the fix? I would implement it.

cforce commented 11 years ago

ist also broken for redmine 2.3.3