search

hdima / python-syntax

Python syntax highlighting script for Vim
http://www.vim.org/scripts/script.php?script_id=790
MIT License
363 stars 109 forks source link

To recognize non-alphanumeric tokens #28

Closed NLKNguyen closed 9 years ago

NLKNguyen commented 9 years ago

Hi, I design this Paper Color theme, and it supports your syntax plugin. Do you plan to make your plugin to recognize non-alphanumeric tokens like ( ) [ ] , . + - * / = < > ?

hdima commented 9 years ago

Hmm, I don't think so. It seems there's no reason to do that for Python syntax.

I've checked your color scheme and I think you probably shouldn't use syntax groups local to syntax highlighting scripts directly. Local groups can be changed without notice. If you check some other Vim color schemes they all map colors to syntax groups. You can see syntax groups in Vim with :help group-name and also :help highlight-groups.

NLKNguyen commented 9 years ago

I see. I just feel like the local groups in your script enable a lot of design opportunities, and they're just too good to be wasted :). Actually, this color scheme already defined colors for standard syntax groups (I based on Tomorrow), so it has some predefined colors to fall back in case the script's local groups changed. The fact is when the syntax plugin becomes mature, it's likely to stay mostly the same for years like many other syntax plugins.

Oh and the reason I asked about a group for those symbols is because it can make the syntax look nicer with those symbols more distinguishable, like the operators, parens, and delimiters in this sample script. dtrace

hdima commented 9 years ago

In my opinion syntax highlighting for code should help to easily recognize code elements that matters. So I don't think that highlighting for punctuation characters is a good idea in case of Python.