Open achimnol opened 8 years ago
It works great for me, thank you!
Seems like @hdima is rare guest on github lately. But this is the best known vim python syntax repository. Maybe someone should take lead of this repo, someone who atleast can review and accept pull requests?
That will need privileges granted by hdima, or we can only have forks. I'm already maintaining my own fork.
@achimnol
Thanks you for you work.
I seems that pythonTypeArgs
is not correctly matched.
I highlight type annotation with red italic font, thus your can see the bug directly.
red arrow indicate the code that should not mark as python type annotation.
as I know Vim runtime has python syntax file. so what is the differences? and why is can not be merged into Vim core repo?
@achimnol @yech1990 don't include pythonTypeArgs
in pythonTypeExpression
. pythonTypeArgs
should only be contained in pythonType*
, not everywhere pythonTypeExpression
can be contained.
@lilydjwg Thank you for your reply. I remove pythonTypeArgs
from L213 and python list is rendered correctly now. Is there any other bug I didn't notice?
@yech1990 No. I was using another version. I've switched to this version since it has more features. I'll comment here if I notice anything wrong.
@yech1990 here's another bug:
def func():
a = call(x | y)
y
will be highlighted as pythonTypeUnion
.
PR for #58 and #59. Finally I figured out how to "embed" other syntax inside a region using
syn cluster
. Python keywords, numbers, booleans, and builtins are highlighted inside f-string braced regions. I tried to prevent the content inside braces from being highlighted as "Special" while keeping the braces and format string highlighted, but could not separate them. Still, I think this version much improves readability.Comments, optimizations, and fixes are welcome.