search

hdl / bazel_rules_hdl

Hardware Description Language (Verilog, VHDL, Chisel, nMigen, etc) with open tools (Yosys, Verilator, OpenROAD, etc) rules for Bazel (https://bazel.build)
Apache License 2.0
119 stars 44 forks source link

bump net_zlib to v1.3.1 #346

Closed PeterAaser closed 3 months ago

PeterAaser commented 3 months ago

v 1.2.11 causes warnings which are fixed here: https://github.com/madler/zlib/commit/e9d5486e6635141f589e110fd789648aa08e9544

Without this we get errors along the lines of

external/net_zlib/trees.c:379:20: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
mikesinouye commented 3 months ago

/gcbrun

PeterAaser commented 3 months ago

I just realized I ran tests in the wrong repo, so it's not unlikely that this PR is broken. I'm not at a computer until tomorrow so I cannot verify. Terribly sorry, this is not a great first impression...

PeterAaser commented 3 months ago

Things came up. I'm not able to actually run these tests so I'm closing this until I'm back at the computer.