search

hdl / conda-eda

Conda recipes for FPGA EDA tools for simulation, synthesis, place and route and bitstream generation.
https://anaconda.org/LiteX-Hub
Apache License 2.0
95 stars 26 forks source link

Add constructor based installer #247

Open proppy opened 2 years ago

proppy commented 2 years ago

Depends on #246 Fixes #245

Test with:

curl -L -O https://github.com/proppy/conda-eda/releases/download/v0.0-1358-g4ea08b3/openlane-sky130a-0-Linux-x86_64.sh
bash openlane-sky130a-0-Linux-x86_64.sh -b -p silicon-env/
source silicon-env/bin/activate 
flow.tcl -design inverter

/cc @QuantamHD @umarcor @mithro

mithro commented 2 years ago

@PiotrZierhoffer / @umarcor - Could you please review? I think it looks fine and thus we should merge but are unsure about the failures?

mithro commented 2 years ago

@proppy - Any idea why things are failing in the CI?

proppy commented 2 years ago

seems unrelated, nightly CI has similar failure: https://github.com/hdl/conda-eda/actions/runs/3253556045

proppy commented 2 years ago

but we can get https://github.com/hdl/conda-eda/pull/246 reviewed indepently if it eases the process.

proppy commented 2 years ago

I tested using the installer and unfortunately stumbled upon such an error:

Can you share the full log? I also have a more recent version of the installer here https://github.com/proppy/conda-eda/releases/tag/v0.0-1418-g170b751

What bothers me a little is that we'll have a tag added for each run of the Construct workflow, i.e., with each Upload workflow run from master. Do I get it right? Isn't there any other option to publish the installer?

I couldn't think of something else if we want to publish the installer as a GitHub release, another possibility it to move them on GCS in timestamped directory, that's something I think would also make sense for packages (see https://github.com/hdl/conda-eda/issues/204).

ajelinski commented 2 years ago

Log: openlane.log

proppy commented 1 year ago

@PiotrZierhoffer, @umarcor would it make sense to setup a dedicated bucket for those installer artifacts so that we can get rid of the noise that automated tagging would add to the repo (as @ajelinski pointed in https://github.com/hdl/conda-eda/pull/247#pullrequestreview-1145791901)