pnr/openroad disable mpl2

[proppy]

• disable mpl2 until we get or-tools packaged

Fixes #258

[proppy]

@maliberty @donn is mpl2 currently used in OpenLane?

[donn]

@proppy Not that I know of

[maliberty]

openlane mostly uses manual macro placement today afaik

[saicharan0112]

Not sure who is responsible for this, but can this be merged please? Not having the openroad latest conda package is delaying OpenFASOC's tests with the latest version of openroad.

@PiotrZierhoffer can you help here in someway?

cc: @msaligane

[mithro]

@proppy

[proppy]

@saicharan0112 the build need to be fixed first https://github.com/hdl/conda-eda/actions/runs/3499093346/jobs/5860258677

[saicharan0112]

@proppy So this PR is not the complete solution for the openroad build?

[proppy]

@saicharan0112 the goal of that PR is to find out what need to be changed to fix the build ;)

[proppy]

@ajelinski the build seem to pass now: https://github.com/hdl/conda-eda/actions/runs/3540069944/jobs/5942702180 can you review?

[proppy]

@QuantamHD does it look reasonable to you to disable mpl2 for now?

[saicharan0112]

Hi everyone, not sure what's stopping from merging the PR to publish the latest openroad package but just for info the package out there is almost 20 days old and projects like OpenFASoC relies on this package to get the latest openroad binary in the CI. I am sure others, who you were encouraged to use the package, also have no access to the latest version of the binary. It would be really helpful if we have access to the latest version of the binary in the package form in the near future.

Thanks

[QuantamHD]

Yeah you can disable it. Nothing will break, but it's not a desirable state to be in.

[QuantamHD]

@proppy Are the failing CI results related to the patch file?

[proppy]

@QuantamHD nop, the OpenROAD job itself is failing: https://github.com/hdl/conda-eda/actions/runs/3540186266/jobs/5942944935

Nothing will break, but it's not a desirable state to be in.

Is it surfaced in the openroad cli/ui yet? It doesn't seem that OpenLane is using yet per https://github.com/hdl/conda-eda/pull/259#issuecomment-1319494561.

[QuantamHD]

You can call it, but most people aren't using it. It's an automatic macro placer

[proppy]

Merging assuming @QuantamHD and @maliberty are fine with it.

[proppy]

Filed https://github.com/hdl/conda-eda/issues/261 to track re-enabling it.

[saicharan0112]

@proppy the openroad is still failing. Did you see that? https://github.com/hdl/conda-eda/actions/runs/3629708117/jobs/6122235621#step:3:1209

[proppy]

That's confusing because it passed in the presubmit: https://github.com/hdl/conda-eda/actions/runs/3540186266/jobs/5942944935

@ajelinski @PiotrZierhoffer do you have a clue?

[ajelinski]

Error: Failed to render jinja template in /home/runner/work/conda-eda/conda-eda/workdir/recipe/meta.yaml: 'GIT_DESCRIBE_TAG' is undefined

Such an error is almost always because of the patching issue and then the details are reported below: https://github.com/hdl/conda-eda/actions/runs/3629708117/jobs/6122235621#step:3:1256

Command '['/home/runner/work/conda-eda/conda-eda/workdir/conda-env/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmp9nw5r5pn/disable-mpl2.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.

So this is definitely about disable-mpl2.patch as MPL2 was disabled for macOS in the meantime: https://github.com/The-OpenROAD-Project/OpenROAD/commit/ac6fcd93f4fc88dd1bc11731b43621d2ad898d20