hdl / conda-eda

Conda recipes for FPGA EDA tools for simulation, synthesis, place and route and bitstream generation.
https://anaconda.org/LiteX-Hub
Apache License 2.0
95 stars 26 forks source link

fix exit status of OS sniffing in build scripts #269

Open proppy opened 1 year ago

proppy commented 1 year ago

It seems that the OS sniffing routing of a lot of recipes calls the exit built-in without any argument. https://github.com/hdl/conda-eda/search?q=%22Unknown+OS%22

This causes bash to use the returned status the the status of the most recently executed command as the exit code (which is that case is the status of the preceeding echo command).

Instead we should make sure that we explicitly call exit with the appropriate error status.