search

hdl / containers

Building and deploying container images for open source electronic design automation (EDA)
https://hdl.github.io/containers/
Apache License 2.0
107 stars 24 forks source link

Feature/tool version string #12

Closed se-bi closed 3 years ago

se-bi commented 3 years ago

Hey, as discussed in #4, the first part: adding git to a base building images and get source code later by git clone to derive version strings.

Spoiler alert, due to missing workflow dependencies and change in the base images which is already used for the other changes, those two other builds (nextpnr, yosys) fail on the first run :see_no_evil:

eine commented 3 years ago

adding git to a base building images and get source code later by git clone to derive version strings.

The first commit (adding git) was cherry-picked. Thanks!

The other changes (running tool --version), need to be added in hdl/smoke-tests. Then, bump the submodule here. Let's keep this PR open for handling that, if you want. Or close this and open a new one. As you wish.

Spoiler alert, due to missing workflow dependencies and change in the base images which is already used for the other changes, those two other builds (nextpnr, yosys) fail on the first run 🙈

Yes, this is expected for now. Workflows have dispatch keys, and there is a trigger script in subdir .github. But sequencing the workflows was not implemented yet. Currently, all of them are executed at the same time. Hence, there are some races and cross-dependency issue. I told this for you to be aware only. You don't need to worry about it (just test it locally). We'll handle it by rerunning workflows manually for now.

se-bi commented 3 years ago

The first commit (adding git) was cherry-picked. Thanks! Also Thanks!

The other changes (running tool --version), need to be added in hdl/smoke-tests. Indeed.