hdl / containers

Building and deploying container images for open source electronic design automation (EDA)
https://hdl.github.io/containers/
Apache License 2.0
107 stars 24 forks source link

nextpnr: restructure a bit and add pkg images #14

Closed se-bi closed 3 years ago

se-bi commented 3 years ago

Hey, next one, also as discussed in #4.

(builds on #13)

eine commented 3 years ago

LGTM. Do you want to handle doc modifications in this same PR, or will be finish the technical modifications first and we will later document all the changes at once?

se-bi commented 3 years ago

LGTM. Do you want to handle doc modifications in this same PR, or will be finish the technical modifications first and we will later document all the changes at once?

valid point! Though first reaction was kind of :see_no_evil:

After a quick look, seems a lot generated stuff, is it mainly based on the doc/tools.yml?

eine commented 3 years ago

After a quick look, seems a lot generated stuff, is it mainly based on the doc/tools.yml?

Yes, in this case it's editing doc/tools.yml and that will update the table. Then, the graph should be updated. That's trickier because the dot source needs to be edited manually.

Let's merge this as is. In the next PR, please update tools.yml; and don't worry about the graph. I'll see how to handle that.

se-bi commented 3 years ago

what else, than:

 nextpnr:
   url: 'https://hdl.github.io/awesome/items/nextpnr'
+  pkg:
+    - 'nextpnr-ice40'
+    - 'nextpnr-ecp5'
+    - 'nextpnr-generic'
   use:
     - 'nextpnr'
     - 'nextpnr:ice40'
     - 'nextpnr:ecp5'
+    - 'nextpnr:generic'
eine commented 3 years ago

Nothing actually! I believe that's enough for this PR! I was mislead by the next one, which will imply modifying impl. Please, push that here.

se-bi commented 3 years ago

Ok, also done.

...impl for another time.