search

hdl / containers

Building and deploying container images for open source electronic design automation (EDA)
https://hdl.github.io/containers/
Apache License 2.0
106 stars 24 forks source link

Add klayout container. #21

Closed Fatsie closed 3 years ago

Fatsie commented 3 years ago

WIP as it currently uses https://github.com/hdl/smoke-tests/pull/5 which has not been merged yet.

umarcor commented 3 years ago

@Fatsie, shall I review this PR?

Fatsie commented 3 years ago

@Fatsie, shall I review this PR?

I plan to update it to non WIP in coming days, so you can wait til then. Just busy with other things ATM.

Fatsie commented 3 years ago

Pushed new (squashed) commit for review. klayout smoke test is still commented out. Removed WIP flag.

Fatsie commented 3 years ago

I discovered that smoke test could be run without X using the -b option. See https://github.com/hdl/smoke-tests/pull/6 I'll update this PR after that PR is merged.

Fatsie commented 3 years ago

I'll update this PR after that PR is merged.

Force pushed update with smoke-tests enabled.

umarcor commented 3 years ago

Thanks!