umarcor
commented
1 year ago It seems that the dependency on click was introduced in all the sby_*.py scripts during the last month: https://github.com/YosysHQ/sby/commits/master/sbysrc. However, it was not done explicit programmatically. I.e., no requirements.txt file was added and the Makefile was not modified to account for this change.
That is probably because the CI in YosysHQ/sby uses YosysHQ/setup-oss-cad-suite (https://github.com/YosysHQ/sby/blob/master/.github/workflows/ci.yml) and YosysHQ/oss-cad-suite-build did already depend on click before changes were done to sby (see https://github.com/YosysHQ/oss-cad-suite-build#contributing).
Yet, it seems that click is not an explicit dependency of oss-cad-suite neither. According to https://github.com/YosysHQ/oss-cad-suite-build/actions/runs/3717890572/jobs/6305683798, it might be indirectly installed because it is a dependency of Flask.
For now, we are installing click explicitly (see #65). Nonetheless, it would be desirable if sby provided a requirements.txt that we could consume/use.
/cc @tmeissner
As per Nov 29, 2022
/usr/local/share/yosys/python3/sby_core.py references to uninstalled pip package: click