Python 2 to 3 migration changes: format strings

hdl / pyHDLParser

Simple Python parser for extracting HDL (VHDL or Verilog) documentation

https://HDL.github.io/pyHDLParser

MIT License

18 stars 11 forks source link

Python 2 to 3 migration changes: format strings #6

Closed vvvverre closed 2 years ago

vvvverre commented 2 years ago

Changed all the uses of .format to f-strings instead. This solves task 2 from Issue #5.

Signed-off-by: Wouter van Verre woutervanverre@gmail.com

vvvverre commented 2 years ago

On a once over, looks good, just one to go:

Good spot! Not sure how I missed that. I've fixed that now.

I'm new to CI, but I quite like the idea of setting up some small parser tests to sanity check my eyes with PRs like these. So, I'll look to get around to setting something up.

I agree. I have little experience with CI either, but happy to help out with setting that up if needed.

umarcor commented 2 years ago

With regard to CI, @Paebels and me gathered some utilities in pyTooling/Actions during the last months. We are using them in the repos from EDA², in vhdl/pyVHDLModel, in repos from pyTooling, etc. So, if you add tests through pytest or tox (which work locally), we might handle them through the reusable workflows.