hdlx / AltAppSwitcher

Alternative application switcher for Windows
MIT License
38 stars 3 forks source link

Flat uniform icons might be invisible #11

Open hdlx opened 3 weeks ago

hdlx commented 3 weeks ago

Win 10 setting icon for example, is white and uniform. On light theme, it is invisible. We could detect this situation and apply an effect.

mcrampon commented 2 weeks ago

Spotify icon is now white:

image

Perhaps this doesn't necessarily need to happen to all colors?

hdlx commented 2 weeks ago

Hey 🙂 I'm not sure to understand. Some apps switch icons depending on windows theme color, thus handling properly monochrome icons already. It seems to be the case with in your screenshot. In this case, the feature of this ticket would compare the icon with the background, and do nothing since the icon is already visible.

Or, you mean that Spotify icon changed following macappswitcher update? If so, this is not related to this ticket (it has no been implemented yet). However, the UWP icon code used to be inconsistent with taskbar. In a recent update, I tried to improve this. If the icon matches with the taskbar, it's the expected behavior, and the previous one was incorrect. If it doesn't match, I'll try to reproduce the issue 🙂

mcrampon commented 2 weeks ago

Or, you mean that Spotify icon changed following macappswitcher update?

Yep. Used to be green, now is white.

If so, this is not related to this ticket (it has no been implemented yet). However, the UWP icon code used to be inconsistent with taskbar. In a recent update, I tried to improve this. If the icon matches with the taskbar, it's the expected behavior, and the previous one was incorrect. If it doesn't match, I'll try to reproduce the issue 🙂

Yeah, it's green in the taskbar :)

hdlx commented 2 weeks ago

Updated icon logic in the latest release, it should fix the issue you had with Spotify 🙂

mcrampon commented 2 weeks ago

Updated icon logic in the latest release, it should fix the issue you had with Spotify 🙂

Works 👍