search

hdmf-dev / hdmf-common-schema

Specifications for pre-defined data structures provided by HDMF.
Other
3 stars 8 forks source link

add VocabData data_type #21

Closed ajtritt closed 4 years ago

ajtritt commented 4 years ago

This adds a column type that can be used for storing controlled-vocabulary data.

bendichter commented 4 years ago

Though remind me, what's the advantage of doing it this way instead of just using HDF5's built-in enumerated types?

ajtritt commented 4 years ago

@bendichter

Though remind me, what's the advantage of doing it this way instead of just using HDF5's built-in enumerated types?

After the complications between HDF5 references and Zarr, I'm hesitant to add an enum dtype to HDMF. It would also require more tooling to handle a new enum dtype. This is just simpler and easier to implement.

rly commented 4 years ago

This PR is good to go. I've added release notes for this in #24.

rly commented 4 years ago

I recommend getting this tested and working in HDMF before merging here though.